Skip to content

psh, libc: fix tests after trailing slash handling change #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jmaksymowicz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

psh, libc: fix tests after trailing slash handling change #324

jmaksymowicz wants to merge 1 commit into from

Conversation

@jmaksymowicz
Copy link
Contributor

@jmaksymowicz jmaksymowicz commented Feb 16, 2024

Changes to tests after handling of trailing slashes on files was changed: phoenix-rtos/libphoenix#346

Description

Currently libphoenix allows for trailing slashes to be at the end of a path when the last component is a file (not a directory). This PR re-enables one of the libc tests that previously would fail due to this incorrect behavior and changes one of the psh tests that previously expected it.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32-generic-qemu

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@jmaksymowicz jmaksymowicz mentioned this pull request Feb 16, 2024
Open
13 tasks
@github-actions
Copy link

github-actions bot commented Feb 16, 2024

Unit Test Results

6 410 tests   - 736   5 778 ✅  - 659   34m 4s ⏱️ -26s
  354 suites  -  43     617 💤  -  92 
    1 files   ±  0      15 ❌ + 15 

For more details on these failures, see this check.

Results for commit ff86ffa. ± Comparison against base commit b8fbd01.

This pull request removes 736 tests. 
phoenix-rtos-tests/cpp/hello-cpp ‑ riscv64-generic-qemu:phoenix-rtos-tests/cpp/hello-cpp
phoenix-rtos-tests/initfini/main ‑ riscv64-generic-qemu:phoenix-rtos-tests/initfini/main
phoenix-rtos-tests/ioctl/unit ‑ riscv64-generic-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_in
phoenix-rtos-tests/ioctl/unit ‑ riscv64-generic-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_in_big
phoenix-rtos-tests/ioctl/unit ‑ riscv64-generic-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout
phoenix-rtos-tests/ioctl/unit ‑ riscv64-generic-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout_big
phoenix-rtos-tests/ioctl/unit ‑ riscv64-generic-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_out
phoenix-rtos-tests/ioctl/unit ‑ riscv64-generic-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_out_big
phoenix-rtos-tests/ioctl/unit ‑ riscv64-generic-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.in_val
phoenix-rtos-tests/ioctl/unit ‑ riscv64-generic-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.invalid_req
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmaksymowicz